-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[charts] Allow customizing shape in scatter charts #16640
base: master
Are you sure you want to change the base?
Conversation
Deploy preview: https://deploy-preview-16640--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #16640 will degrade performances by 20.01%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, if there are other places you want input, let me know
onClick?: (event: React.MouseEvent<SVGElement, MouseEvent>) => void; | ||
} | ||
|
||
export interface ScatterMarkerOwnerState { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this and merge the props into the ScatterMarkerProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used in Scatter.types.ts
and on ScatterMarkerProps
, so it's probably better to keep it to avoid duplication.
I'll remove it if we have only one usage.
c663548
to
529ac2a
Compare
A lot of the times, the slots are passed to the top component, which means you should be able to pass it around to the |
0062831
to
ba795ba
Compare
Allow customizing shape in scatter charts by using the
marker
slot.This is my first time using slots, so I'm not sure if I'm using them properly and whether the
ownerState
/additionalProps
is well defined.Still need to write the docs, but at the moment I'm only looking for feedback on the implementation.