Skip to content

Commit

Permalink
Merge pull request #7 from muir/compat
Browse files Browse the repository at this point in the history
Minimum compatibility is now tested and is Go 1.15
  • Loading branch information
muir authored Oct 27, 2021
2 parents ec4bc9a + ef7f6c8 commit 212ae7c
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 15 deletions.
26 changes: 13 additions & 13 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
name: Unit tests
on: [ push ]
on: [push, pull_request]
name: Unit Tests
jobs:
Build-and-test:
runs-on: ubuntu-latest
test:
strategy:
matrix:
go-version: [1.15.x, 1.16.x, 1.17.x]
os: [ubuntu-latest, macos-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2

- name: Set up Go
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.16

- name: Build
run: go build -v ./...

go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v2
- name: Test
run: go test -v ./...
run: go test ./...
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,3 +211,7 @@ This repo represents continued development of Blue Owl's
has been in production use for years and has been unchanged for years.
The core of nject is mostly unchanged. Nvelope and nserve are new.
### Go version
Due to the use of strconv.ParseComplex in nvelope, the minimum supported
version of Go is 1.15
3 changes: 1 addition & 2 deletions nvelope/decode.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (
"encoding"
"encoding/json"
"encoding/xml"
"io"
"io/ioutil"
"net/http"
"net/url"
Expand All @@ -30,7 +29,7 @@ func readBody(r *http.Request) (Body, nject.TerminalError) {
// nolint:errcheck
defer r.Body.Close()
body, err := ioutil.ReadAll(r.Body)
r.Body = io.NopCloser(bytes.NewReader(body))
r.Body = ioutil.NopCloser(bytes.NewReader(body))
return Body(body), err
}

Expand Down

0 comments on commit 212ae7c

Please # to comment.