guard against nil {Local,Remote}Addr() return values #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ipfs/kubo#8211. As discussed in ipfs/kubo#8211 (comment), I'm not sure why
LocalAddr()
of anet.Conn
would ever returnnil
, but as evidenced by the stack trace, it can happen (maybe just on certain architectures).Playing it safe, we can check that the value is not
nil
before using it.