added transport to options so it can be used to filter by #28
Conversation
|
question: Was transport left out on purpose for some reason? |
|
The toOptions is a convenience method so that we get an options object that is friendly with Node.js net and http api. we can add this one in. Seems like tests are failing, could you update? |
|
I take a look and see whats up with the tests. |
|
Tests are fixed. |
| @@ -302,6 +302,7 @@ describe('helpers', () => { | |||
| ).to.be.eql({ | |||
| family: 'ipv4', | |||
| host: '0.0.0.0', | |||
| transport: 'tcp', | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
It was complaining about tabs instead of spaces so I fixed that. When I commit I get this error message. Not sure what to do.
Are these the weird Webpack errors mentioned below?
ERROR in multi main
Module not found: Error: Can't resolve 'transform' in '/Users/sidharder/git/js-multiaddr'
BREAKING CHANGE: It's no longer allowed to omit the '-loader' prefix when using loaders.
You need to specify 'transform-loader' instead of 'transform'.
@ multi main
There was a problem hiding this comment.
I rebased master onto my branch but still have same issue?
There was a problem hiding this comment.
OK, I got through it, disregard the previous messages.
|
@SidHarder you might also want to rebase master onto your branch, so that you don't get the weird Webpack errors (the loader ones) |
1 similar comment
|
released :) |
No description provided.