Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[MU4 Issue] Musescore UI not in System Default language #13926

Closed
teetow opened this issue Oct 23, 2022 · 5 comments · Fixed by #14701
Closed

[MU4 Issue] Musescore UI not in System Default language #13926

teetow opened this issue Oct 23, 2022 · 5 comments · Fixed by #14701
Assignees
Labels
P2 Priority: Medium

Comments

@teetow
Copy link

teetow commented Oct 23, 2022

Describe the bug
Musescore shows the incorrect language by default, not respecting its own setting "System Default."

To Reproduce
Steps to reproduce the behavior:

  1. Go to Edit > Preferences
  2. Verify "Language" set to "System Default" (English in my case)
  3. Note that the Musecore UI is in Swedish, which is not my selected Display Language (see screenshots)
  4. Silently wonder why every single multiplatform app gets this wrong

Expected behavior
Musescore UI being in English, as per its Language setting

Screenshots

Windows Display Language setting

image

Platform information

  • OS: Windows 10

Additional context
As mentioned, this is a common screwup in applications where devs mistakenly interpret User Regional formatting settings (stuff like date and time formatting) to mean System Language. Please be one of the good guys here.

@cbjeukendrup
Copy link
Contributor

I'm afraid this might be a Qt problem. We get the system language from Qt, using QLocale::system().uiLanguages().
Although Qt intends that this is the correct way to retrieve the display language, we might try another way.

@teetow
Copy link
Author

teetow commented Oct 23, 2022

Hmm. I whipped up a quick test app (in PyQt5, granted) and it gave me the following values for the settings I could scrounge up from various SO answers:

image

So, the only place where Swedish shows up is indeed in QLocale::system()::uiLanguages(). Now, I can't really make heads or tails of all the stuff in languageService.cpp but I'm seeing references to languageCode which makes me believe that (at least on my machine) the last code in that list gets picked as the assumed system language.

Good news is, you have two other methods that (again, on my machine) yields English -- QLocale.system().language() and QLocale.system().name(). So maybe there's some hope.

@Tantacrul
Copy link
Contributor

@cbjeukendrup - can you prioritise (4.x, post-beta, release etc.)? If we think it's an easy, quick fix, then release would be appropriate.

@cbjeukendrup
Copy link
Contributor

@teetow There's a small chance that this is fixed by #14701. Could you please try the builds from that PR?

@teetow
Copy link
Author

teetow commented Nov 24, 2022

@teetow There's a small chance that this is fixed by #14701. Could you please try the builds from that PR?

I did, and the issue is no longer present.

For what it's worth, it's also not present in the build currently on MuseHub (info pasted below).

image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P2 Priority: Medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants