Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[RFE] Add option to change language #271

Closed
nicki419 opened this issue Nov 9, 2020 · 8 comments · Fixed by #765
Closed

[RFE] Add option to change language #271

nicki419 opened this issue Nov 9, 2020 · 8 comments · Fixed by #765

Comments

@nicki419
Copy link

nicki419 commented Nov 9, 2020

My Windows Language is English (US), my default app language is English (US) but my region is set to Germany, and so are date and time formats. For some reasons, many programs, including Fedora Media Writer think it's appropriate to ignore Windows and APP languages and orientate on region settings. I didn't set my language to Enlgish (US) to use all my apps in German.

Please change that.

@rasmuoy
Copy link

rasmuoy commented May 6, 2021

I have same issue, Norwegian keyboard, and Norwegian region settings - however OS language and every relevant setting this app should care about is set to English. It's extremely frustrating to work with a Norwegian application when it has no reason to do so.

Please follow a sane standard and use system language and not region settings for language settings.

Edit: Apparently only parts of the app shows up in regional language, other parts are indeed in English. This might be due to lack of translation? For the Official release of desktop and server, things are in Norwegian - for the others, it's English.

@grulja grulja changed the title Wrong language and no way to change it [RFE] Add option to change language May 13, 2021
@teetow
Copy link

teetow commented Nov 13, 2024

Same issue. The Swedish word-for-word translation is so bad I didn't dare to use it, the options are all completely incomprehensible. This is not a feature request, it's a legit bug.

Steps to reproduce:

  • Set Windows system language to English
  • Select Swedish for regional info (numbers and dates)
  • Bug happens

Check this comment for some digging I did when Musescore fell into the same Qt problem:

musescore/MuseScore#13926 (comment)

From my understanding, you want either QLocale.system().language() or QLocale.system().name(), not whatever QLocalesystem().uiLanguages() is.

@grulja
Copy link
Collaborator

grulja commented Nov 14, 2024

Same issue. The Swedish word-for-word translation is so bad I didn't dare to use it, the options are all completely incomprehensible. This is not a feature request, it's a legit bug.

You can try to suggest better translation here https://translate.fedoraproject.org/projects/fedora-media-writer/.

@teetow
Copy link

teetow commented Nov 14, 2024

Very few Swedes need (or indeed want) localization, especially for a technical tool like this. It just increases the cognitive tax of using it, as there are few established terms for things like "release" and whatever the hell "utgåva" is meant to translate. I think it would be prudent to respect that localization is only useful for certain users, to others it's a hindrance. Following the system language is how everyone gets what they want.

Frankly, if the bug is fixed, it won't matter how bad the translation is. Did you look into the information I provided? Is it applicable?

@teetow
Copy link

teetow commented Nov 14, 2024

As an example, the established Swedish translation for "release" is... "release."

@rasmuoy
Copy link

rasmuoy commented Nov 14, 2024

I strongly agree with @teetow here. This is not a feature request for allowing a change of language, it is a bug report asking for the app to respect the choice already made.

Why is it looking at time and currency format to select the language? It makes no sense, and they are not the same.

Time and currency format is there to say I want my dates to be dd.mm.yyyy instead of mm.dd.yyyy and for commas to be the decimal marker instead of periods. It is completely unrelated to language.

And region (just in case that is what is being used) is just the place I live/is currently located, again unrelated to what language I want, or even know.

The app should obviously follow the system language, as in the language we have selected to be displayed on our system.

This should hopefully be a very minor fix, but helps people in our situation a lot.

grulja added a commit to grulja/MediaWriter that referenced this issue Nov 21, 2024
Using QLocale::system() gives the correct locale, but uiLanguages() can
give us language we don't want to. Instead just construct a new QLocale
with the language reported as primary by QLocale::system().

Fixes FedoraQt#271
@grulja
Copy link
Collaborator

grulja commented Nov 21, 2024

I proposed a fix here #765. You can test it by downloading articts from here https://github.com/FedoraQt/MediaWriter/actions/runs/11952903378 once the CI finishes. There should be a Windows installer available.

@grulja grulja closed this as completed in 0e69a17 Nov 22, 2024
grulja added a commit that referenced this issue Nov 22, 2024
Using QLocale::system() gives the correct locale, but uiLanguages() can
give us language we don't want to. Instead just construct a new QLocale
with the language reported as primary by QLocale::system().

Fixes #271
@rd77g
Copy link

rd77g commented Jan 8, 2025

just downloaded win64-5.2.3 version and still autotranslates to locale language instead of UI language. Windows (and every application I do install) are set to English although my locale is not. The installer is in English but the main application is not.

I also tried a clean install from https://github.com/FedoraQt/MediaWriter/actions/runs/11952903378 just in case but same result

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants