Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

updated Maple Leaf Rag #62

Merged
merged 2 commits into from
Jan 19, 2021
Merged

updated Maple Leaf Rag #62

merged 2 commits into from
Jan 19, 2021

Conversation

rettinghaus
Copy link
Member

This PR brings following:

  • Changed doubled accid attribute on note to accid.ges
  • Removed tie attributes
  • Fixed clef changes
  • Added missing rests
  • Removed unnessesary scoreDefs
  • Formatting

fixes #61

@rettinghaus rettinghaus mentioned this pull request Dec 1, 2020
Closed
@heinzr
Copy link

heinzr commented Dec 3, 2020 •
edited
Loading

Thanks Klaus!
One question: in measure 8 and 42 (staff 1, layer 1)-I see an element followed by a element. I think the element serves no useful purpose, though it does not do any harm.

@rettinghaus
Copy link
Member Author

@heinzr thanks again for pointing this out. I removed those unnecessary space elements.

@rettinghaus rettinghaus requested a review from bwbohl December 29, 2020 20:56
@bwbohl bwbohl merged commit 0b20f85 into music-encoding:master Jan 19, 2021
@bwbohl
Copy link
Member

bwbohl commented Jan 19, 2021

@rettinghaus @heinzr thanks to both of you

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bwbohl bwbohl Awaiting requested review from bwbohl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in Scott Joplin Maple Leaf Rag
3 participants
@rettinghaus @heinzr @bwbohl