Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

move soliton initialisation into package #171

Closed
1 of 2 tasks
musoke opened this issue Jan 15, 2024 · 1 comment · Fixed by #178
Closed
1 of 2 tasks

move soliton initialisation into package #171

musoke opened this issue Jan 15, 2024 · 1 comment · Fixed by #178
Labels
enhancement New feature or request
Milestone
JOSS review

Comments

@musoke
Copy link
Owner

musoke commented Jan 15, 2024 •
edited
Loading

Soliton initialisation is currently in an example.

  • Move it into the package properly.
  • Move given profile into an artifact.
@musoke musoke added the enhancement New feature or request label Jan 15, 2024
@musoke musoke added this to the JOSS submission milestone Jan 15, 2024
@musoke musoke linked a pull request Jan 26, 2024 that will close this issue
feat: Soliton initialisation #178
Merged
@musoke
Copy link
Owner Author

musoke commented Jan 26, 2024

Moving the profile into an artifact didn't seem worth the effort. DataDeps is nice, but then one can't use the artifacts during precompilation without setting an env variable. That would be another step for users.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
JOSS review
Development

Successfully merging a pull request may close this issue.

feat: Soliton initialisation musoke/UltraDark.jl
1 participant
@musoke