Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Soliton initialisation #178

Merged
merged 2 commits into from
Jan 26, 2024
Merged

feat: Soliton initialisation #178

merged 2 commits into from
Jan 26, 2024

Conversation

musoke
Copy link
Owner

@musoke musoke commented Jan 26, 2024

Previously soliton initialisation was in a script which was imported in some examples. Move this into the package as a function so it is properly documented and tested.

Add this function to precompilation.

Previously soliton initialisation was in a script which was imported in
some examples.  Move this into the package as a function so it is
properly documented and tested.

Add this function to precompilation.
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (786dbc6) 84.96% compared to head (fbb2002) 85.58%.

Files Patch % Lines
src/initialise.jl 96.42% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   84.96%   85.58%   +0.61%     
==========================================
  Files           8        9       +1     
  Lines         612      645      +33     
==========================================
+ Hits          520      552      +32     
- Misses         92       93       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@musoke musoke linked an issue Jan 26, 2024 that may be closed by this pull request
2 tasks
@musoke musoke merged commit 7d53588 into main Jan 26, 2024
15 checks passed
@musoke musoke deleted the init-into-pkg branch January 26, 2024 22:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move soliton initialisation into package
1 participant