Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

bouncePreviewForDrawerSide doesn't pass completion block #367

Closed
eytanbiala opened this issue Apr 18, 2015 · 1 comment
Closed

bouncePreviewForDrawerSide doesn't pass completion block #367

eytanbiala opened this issue Apr 18, 2015 · 1 comment

Comments

@eytanbiala
Copy link
Contributor

bouncePreviewForDrawerSide passes nil to the completion block handler:

-(void)bouncePreviewForDrawerSide:(MMDrawerSide)drawerSide completion:(void(^)(BOOL finished))completion{
    NSParameterAssert(drawerSide!=MMDrawerSideNone);
    [self bouncePreviewForDrawerSide:drawerSide distance:MMDrawerDefaultBounceDistance completion:nil];
}
danmurrelljr pushed a commit that referenced this issue May 9, 2015
Merge pull request #368 from eytanbiala/367
08b1538 
Fixes #367
@danmurrelljr
Copy link
Contributor

Got it, thanks.

boherna added a commit to boherna/MMDrawerController that referenced this issue Sep 4, 2015
@boherna
Merge remote-tracking branch 'upstream/master'
624a645 
* upstream/master: (21 commits)
  Fixes mutualmobile#367
  Added notes for reference
  Add missing appearance transition forwarding
  Fixed changelog
  Updated changelog
  Updated changelog
  updated changelog
  Fix infinite, recursive init call for subclass
  Replaced iOS 6 deprecated `-shouldAutorotateToInterfaceOrientation:` method with new one
  Cleaned up PR mutualmobile#288
  Prevent several rotation methods from getting called twice in iOS8, where they are automatically called from [UIViewController viewWillTransitionToSizeWithTransitionCoordinator:]
  Update MMDrawerController.m
  Updated documentation
  Removed pre iOS 7 support
  Switched id to instancetype
  Fix for mutualmobile#287
  Added iPhone 6/6+ support
  Cleaned up setter methods Added shadow color property from mutualmobile#294
  Updated UI properties from mutualmobile#338
  Call removeFromParentViewController after removeFromSuperview in setCenterViewController to avoid EXC_BAD_ACCESS due to nil view value
  ...

Conflicts:
	MMDrawerController/MMDrawerController.h
	MMDrawerController/MMDrawerController.m
glt3953 added a commit to glt3953/MMDrawerController that referenced this issue Apr 8, 2024
@glt3953
Merge pull request mutualmobile#368 from eytanbiala/367
988c462 
Fixes mutualmobile#367
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danmurrelljr @eytanbiala