Compile cleanly with -Wunreachable-code #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unreachable due to the return on the previous line.
The bottom half of this is unreachable due to the if having a simple else case.
|
Thanks man 🍻 |
kcharwood
added a commit
that referenced
this pull request
Apr 2, 2014
Compile cleanly with -Wunreachable-code
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Apple's recent security blunder, I turned -Wunreachable-code on in my projects. I found a couple places were MMDrawerController doesn't compile cleanly under this: one in the MMDrawerController.m, the other in the sample project. This pull request fixes both.
See: https://www.imperialviolet.org/2014/02/22/applebug.html