Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Manually-paused uploads don't resume again #27

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

daytime-em
Copy link
Collaborator

@daytime-em daytime-em commented Jun 6, 2023

Uploads wouldn't start because the internal ChunkedFileUploader was in the failed state improperly. CancellationError should send it to the paused state. This works for normal cancellation too

@daytime-em daytime-em requested a review from a team as a code owner June 6, 2023 00:21
@daytime-em daytime-em changed the base branch from main to releases/v0.3.1 June 6, 2023 00:23
@daytime-em daytime-em changed the title fix: Resumed uploads don't start again fix: Manually- paused uploads don't resume again Jun 6, 2023
@daytime-em daytime-em changed the title fix: Manually- paused uploads don't resume again fix: Manually-paused uploads don't resume again Jun 6, 2023
@daytime-em daytime-em merged commit d1bf9b7 into releases/v0.3.1 Jun 6, 2023
@daytime-em daytime-em deleted the fix/resume-broken branch June 6, 2023 16:41
@daytime-em daytime-em added the fixes Labeled under "Fixes" on the release notes label Jun 6, 2023
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
daytime-em added a commit that referenced this pull request Jun 6, 2023
## Fixes

* fix: Manually-paused uploads don't resume again (#27)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
andrewjl-mux pushed a commit that referenced this pull request Jun 8, 2023
## Fixes

* fix: Manually-paused uploads don't resume again (#27)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
andrewjl-mux pushed a commit that referenced this pull request Jun 9, 2023
## Fixes

* fix: Manually-paused uploads don't resume again (#27)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
andrewjl-mux pushed a commit that referenced this pull request Jun 12, 2023
## Fixes

* fix: Manually-paused uploads don't resume again (#27)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
andrewjl-mux pushed a commit that referenced this pull request Jun 12, 2023
## Fixes

* fix: Manually-paused uploads don't resume again (#27)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
tomkordic pushed a commit that referenced this pull request Mar 1, 2024
## Fixes

* fix: Manually-paused uploads don't resume again (#27)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
fixes Labeled under "Fixes" on the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants