Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Track upload statistics #3

Merged
merged 10 commits into from
Mar 27, 2023
Merged

Track upload statistics #3

merged 10 commits into from
Mar 27, 2023

Conversation

refactornator
Copy link
Contributor

No description provided.

@refactornator refactornator requested a review from a team as a code owner March 15, 2023 23:49
daytime-em
daytime-em requested changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@daytime-em daytime-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question that keeps me from being comfortable merging

@daytime-em daytime-em changed the base branch from main to releases/v0.2.1 March 15, 2023 23:57
daytime-em
daytime-em requested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@daytime-em daytime-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one style thing, but otherwise this looks great!!

@refactornator refactornator marked this pull request as draft March 20, 2023 18:42
@refactornator refactornator marked this pull request as ready for review March 22, 2023 21:48
@refactornator refactornator changed the title Track upload statistics using Sentry Track upload statistics Mar 22, 2023
daytime-em
daytime-em requested changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@daytime-em daytime-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a version bump

@refactornator
Copy link
Contributor Author

refactornator commented Mar 24, 2023 •
edited
Loading

All of the requested changes are in and ready for another review @daytime-em @andrewjl-mux

@andrewjl-mux andrewjl-mux self-requested a review March 25, 2023 00:27
andrewjl-mux
andrewjl-mux approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@andrewjl-mux andrewjl-mux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective

@refactornator refactornator merged commit 8f451ac into releases/v0.2.1 Mar 27, 2023
@refactornator refactornator deleted the ll/add-sentry branch March 27, 2023 22:01
@github-actions github-actions bot mentioned this pull request Apr 6, 2023
Merged
daytime-em added a commit that referenced this pull request Apr 6, 2023
@daytime-em @refactornator
Releases/v0.2.1
63cb5ee 
## Improvements

* Track upload statistics (#3)
* fix: Resumed Uploads start at the beginning of the file (#7)

Co-authored-by: Liam Lindner <liam@mux.com>
Co-authored-by: Emily Dixon <edixon@mux.com>
@andrewjl-mux andrewjl-mux mentioned this pull request Jul 8, 2023
Merged
tomkordic pushed a commit that referenced this pull request Mar 1, 2024
@daytime-em @refactornator
Releases/v0.2.1
413a6c7 
## Improvements

* Track upload statistics (#3)
* fix: Resumed Uploads start at the beginning of the file (#7)

Co-authored-by: Liam Lindner <liam@mux.com>
Co-authored-by: Emily Dixon <edixon@mux.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@daytime-em daytime-em

@andrewjl-mux andrewjl-mux

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refactornator @daytime-em @andrewjl-mux