Use MuxUpload id instead if the input URL when looking up or writing … #31
Conversation
andrewjl-mux
force-pushed
the
ajlb/read-and-write-upload-state-using-id
branch
from
a2c0604 to
ec6ea05
Compare
andrewjl-mux
changed the base branch from
ajlb/use-uuid-string-muxupload-internal-identifier
to
releases/v0.4.0
|
@daytime-em will be adding a few more changes here Changed the |
| // Shouldn't throw (but not specifically part of the test) | ||
| try! persistence.write(entry: e1, forFileAt: makeDummyFileURL(basename: "e1")) | ||
| try! persistence.write(entry: e2, forFileAt: makeDummyFileURL(basename: "e2")) | ||
| XCTAssertNoThrow( |
There was a problem hiding this comment.
XCTAssertNoThrow is effectively the same as try! (the test will fail and throw either way if this expression throws). One bonus behind asserting here is it does also allow us to pass a string that gets printed when a specific assertion fails.
| let readItem1 = try XCTUnwrap( | ||
| persistence.readEntry(uploadID: e2.uploadInfo.id) | ||
| ) | ||
| let readItem2 = try XCTUnwrap( |
There was a problem hiding this comment.
Converts what is otherwise a crash into a failing test. More here: https://useyourloaf.com/blog/xctunwrap-optionals-in-your-tests/
| e1.uploadInfo.videoFile, | ||
| "read() should return the right item" | ||
| ) | ||
| XCTAssertEqual( | ||
| // remember, they're swapped | ||
| readItem1!.uploadInfo.videoFile, | ||
| readItem1.uploadInfo.videoFile, |
There was a problem hiding this comment.
The ! can now be removed due to the XCTUnwrap above.
…state in the SDK