Add an overload initializer for UploadOptions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjl-mux
force-pushed
the
ajlb/api-adjustments-for-guide
branch
from
2a5aafb to
4291ce2
Compare
andrewjl-mux
force-pushed
the
ajlb/api-adjustments-for-guide
branch
from
4291ce2 to
13ce78a
Compare
andrewjl-mux
commented
Jul 27, 2023
| public init( | ||
| eventTracking: EventTracking = .default, | ||
| inputStandardization: InputStandardization = .default, | ||
| chunkSizeInBytes: Int = 8 * 1024 * 1024, |
There was a problem hiding this comment.
Swift won't allow use of a constant as a default argument in a publicly accessible method unless it is also made publicly accessible. Need to think through the right spelling for these before exposing so for now they're (sadly) repeated literals.
daytime-em
approved these changes
Jul 27, 2023
Merged
andrewjl-mux
added a commit
that referenced
this pull request
Jul 31, 2023
tomkordic
pushed a commit
that referenced
this pull request
Mar 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.