Code cleanups; RUSTSEC/CVE fix #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bumped bitflags version to > 1 to avoid try!() warnings. Edited bitflags code for compatibility. * Replaced mem_transmute() with Box::from_raw() in stream.rs as suggested by comments there. * Cleaned up all compiler warnings. * Cleaned up all Clippy warnings.
Two uses of mem::forget() after user callbacks were replaced with Box::leak() before the user callbacks to ensure that unowned memory was not improperly freed on panic.
|
Oops. Had forgotten to look at the examples. Those are cleaned up by the third patch. |
|
Looks good to me, thanks! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch: bring the code up to date with the current ecosystem. (Unfortunately this requires bumping the minimum required version of
bitflagsto at least 1.0.)Second patch: attempt to fix the RUSTSEC/CVE issue noted in Issue Stream callback procedure is not unwind safe #20. This patch could use a careful audit to ensure I understood the vulnerability and the fix.
Thanks much for
portaudio-rs. I'm using it in projects and really happy with it.