Added default version number to SymbolLib #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvnmgrx
requested changes
Feb 20, 2023
src/kiutils/symbol.py
Outdated
| @@ -426,7 +426,7 @@ class SymbolLib(): | |||
| Documentation: | |||
| https://dev-docs.kicad.org/en/file-formats/sexpr-symbol-lib/ | |||
| """ | |||
| version: Optional[str] = None | |||
| version: str = "20211014" | |||
There was a problem hiding this comment.
Please change to
version: str = KIUTILS_CREATE_NEW_VERSION_STR;
and add on top of the file:
from kiutils.misc.config import KIUTILS_CREATE_NEW_VERSION_STR
There was a problem hiding this comment.
Ah, brilliant. Thank you for the note.
|
Indeed, the version number being optional is an oversight. I've added a minor comment to your changes, because we have a config file for that. I'm happy to merge your PR after that. |
|
Thank you for the suggestions. They are now implemented. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kiutils.symbol.SymbolLibdoes not have a default version number in KiUtils. ASymbolLibcreated in KiUtils that is then imported into KiCad fails to load due to the version number being "None", but KiCad 6.0 expects a version number.This change uses the version number obtained from files migrated from
.libto.kicad_symby KiCad's manager UI.