Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

change virustotal flag to -V #440

Merged
merged 1 commit into from
Jan 10, 2024
Merged

change virustotal flag to -V #440

merged 1 commit into from
Jan 10, 2024

Conversation

r-tx
Copy link
Contributor

@r-tx r-tx commented Dec 20, 2023

for the download-apks command -v is defined as shorthand for both --virustotal and --verbose.

Suggesting to change --virustotal to use -V (upper v) for short.

Copy link
Contributor

@roaree roaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot! This seems like a backwards compatible change too - running main on my machine, passing -v currently sets verbose=True and virustotal=False.

Will leave open a day or two in case folks have other thoughts

@roaree roaree merged commit 1182587 into mvt-project:main Jan 10, 2024
4 checks passed
@r-tx r-tx deleted the fix-vt-flag branch January 15, 2024 12:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants