-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Configure project to use pyproject.toml and consistent CI and test tooling #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyPy checks should be renabled once the types are fixed in #545
The code coverage is broken in this PR. Pytest is run using the installed packaged and coverage is shown for the installed package rather than the source directory. I'm making a note here as I don't have time to dig into this currently. @roaree Have you seen this before?
|
The last two commits appear to have fixed the code coverage collection and reporting. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the project to make development tooling more consistent and approachable in future.
pyproject.toml
filesrc
project layoutblack
- useruff
's formatterflake8
- useruff
's linter but enable the same ruleset as the previousflake8
configdev/*
scriptsMakefile changes
make install
installs as an editable package which can be used for development.make test-requirements
installs the test requirementsmake check
runs all linting withruff
and type checks withmypy
make autofix
autofixes any fixable linting/formatting errors withruff
.make test
runs all testsNote: latest
pip
andbuild
packages are required.