Show characters typed in decrypt-backup #594
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the improvement request to show characters typed in decrypt-backup as asterisks (*), so that people can follow the characters they typed (#581)
The rich library currently used by MVT does seem to support this feature.
The builtin password support of the library leads to the characters being completely hidden.
Using the popular promt_toolkit instead:
When the is_password=True flag has been given, the input is replaced by asterisks (* characters).
The downside is that another library is used for password inputs.
However, this is a fairly simple solution for the issue.
Alternatively, one could also try and write a custom password prompt using the rich library.