Feature: allow different snap modes used for grid size and offset #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds more control on the evaluation of grid size and offset from input bounds, which is used with most Grid classmethods.
The default snap mode
full
will snap bounds to a multiple of resolution, which has been the only mode up until now.Some other modes include:
half
: snap to half-resolution, for instance when creating a finite-element grid where the representative value is at grid corners, thus it need to be shifted by a half grid resolution.top-left
,top-right
,bottom-left
, orbottom-right
: snap to corner, without rounding any digits.There are a few instances where the behaviour has changed, only when a buffer distance was also provided. These previous grids were not large enough to contain the original bounds, and is corrected here.
Also, some classmethods have been modified to force some keywords to be specified (rather than just positional).