Add LSST schema v_2 and v_3 #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troyraen
approved these changes
Feb 13, 2025
Comment on lines
-39
to
+40
| - name: 'lsst.v7_1.alert' | ||
| path: 'schemas/lsst/7/1/lsst.v7_1.alert.avsc' | ||
| - name: 'lsst.v7_3.alert' | ||
| path: 'schemas/lsst/7/3/lsst.v7_3.alert.avsc' |
There was a problem hiding this comment.
I think all three schema versions need to be registered here in order to be usable.
| @@ -76,12 +76,12 @@ def elasticc_schema_helper(schema_dict: dict) -> "Schema": | |||
|
|
|||
| @staticmethod | |||
| def lsst_schema_helper(schema_dict: dict) -> "Schema": | |||
There was a problem hiding this comment.
This function should also specify all schema versions that are available.
There was a problem hiding this comment.
Add a readme or something that explains where these files came from.
|
Oh, please also update CHANGELOG.md. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSST schema versions 7.2 and 7.3 are now available. This PR creates subdirectories containing schema information to
pittgoogle/schemas/lsst/7and updatesschemas.pyby settinglsst.v7_3.alertas the default schema (i.e.,lsst.v7_1.alert->lsst.v7_3.alert.I believe these changes cover all of the bases outlined in add a new schema to the registry.