-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feature: separate job_factory, introduce auto_remove option and custom server name_templates #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Mar 24, 2024
Merged
Hi @mj0nez, thank you very much for you're contribution. I'm going to review asap. Very excited that this project is adopted by others :) |
@mj0nez thank you, the PR looks awesome! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for this project! I've recently adopted it at work but had to do some changes, which could be useful.
This PR introduces the following changes:
name_template
to customize the server naming; which allows more speaking job namesauto_remove_jobs
config to remove Nomad jobs after the server stops (defaults to False)job_factory
fromstart
to allow customization by server operators;useful if the spawning does not require user interaction, you want a more homogenous cluster or there are some defaults you want to set
fetch_from_service_provider
from `start;to allow custom logic to fetch the spawned server's address and port (e.g. you want to fetch a consul service via the Nomad API)