Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: separate job_factory, introduce auto_remove option and custom server name_templates #8

Merged
merged 17 commits into from
Mar 28, 2024

Conversation

mj0nez
Copy link
Contributor

@mj0nez mj0nez commented Mar 24, 2024

Hi,

Thank you for this project! I've recently adopted it at work but had to do some changes, which could be useful.

This PR introduces the following changes:

  • introduce name_template to customize the server naming; which allows more speaking job names
  • add auto_remove_jobs config to remove Nomad jobs after the server stops (defaults to False)
  • extracted job_factory from start to allow customization by server operators;
    useful if the spawning does not require user interaction, you want a more homogenous cluster or there are some defaults you want to set
  • extracted fetch_from_service_provider from `start;
    to allow custom logic to fetch the spawned server's address and port (e.g. you want to fetch a consul service via the Nomad API)
  • added some recipes and improved the docs

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Mar 24, 2024
@mxab
Copy link
Owner

mxab commented Mar 24, 2024

Hi @mj0nez, thank you very much for you're contribution. I'm going to review asap.

Very excited that this project is adopted by others :)

@mxab mxab merged commit 4d57047 into mxab:main Mar 28, 2024
2 of 3 checks passed
@mxab
Copy link
Owner

mxab commented Mar 28, 2024

@mj0nez thank you, the PR looks awesome!

@mj0nez mj0nez deleted the feature/make-user-form-optional branch March 28, 2024 13:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants