[ISSUE #2209]🚸Implement DefaultMappedFile#get_mapped_byte_buffer🍻

mxsm · Jan 11, 2025 · 773475a · 773475a
1 parent 8bdcd30
commit 773475a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/rocketmq-store/src/log_file/mapped_file.rs b/rocketmq-store/src/log_file/mapped_file.rs
@@ -368,7 +368,7 @@ pub trait MappedFile {
     ///
     /// # Returns
     /// A `bytes::Bytes` instance containing the byte buffer of the entire mapped file.
-    fn get_mapped_byte_buffer(&self) -> bytes::Bytes;
+    fn get_mapped_byte_buffer(&self) -> &[u8];
 
     /// Creates a slice of the mapped byte buffer.
     ///
@@ -614,7 +614,6 @@ pub trait MappedFileRefactor {
         cb: &dyn CompactionAppendMsgCallback,
     ) -> AppendMessageResult;
 
-    fn get_mapped_byte_buffer(&self) -> &[u8];
     fn slice_byte_buffer(&self) -> &[u8];
     fn get_store_timestamp(&self) -> u64;
     fn get_last_modified_timestamp(&self) -> u64;

diff --git a/rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs b/rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs
@@ -524,8 +524,10 @@ impl MappedFile for DefaultMappedFile {
     }
 
     #[inline]
-    fn get_mapped_byte_buffer(&self) -> Bytes {
-        todo!()
+    fn get_mapped_byte_buffer(&self) -> &[u8] {
+        self.mapped_byte_buffer_access_count_since_last_swap
+            .fetch_add(1, Ordering::AcqRel);
+        self.mmapped_file.as_ref()
     }
 
     #[inline]