[ISSUE #2234]⚡️Optimize BrokerRuntimeInner register_broker_all method…

… paramters🦺 (#2235)
mxsm · Jan 14, 2025 · 9896960 · 9896960
1 parent ccd0e7c
commit 9896960
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/rocketmq-broker/src/broker_runtime.rs b/rocketmq-broker/src/broker_runtime.rs
@@ -1093,11 +1093,13 @@ impl<MS: MessageStore> BrokerRuntimeInner<MS> {
                 topic_config_wrapper,
                 vec![],
                 oneway,
-                10000,
-                false,
-                false,
-                None,
-                Default::default(),
+                this.broker_config.register_broker_timeout_mills as u64,
+                this.broker_config.enable_slave_acting_master,
+                this.broker_config.compressed_register,
+                this.broker_config
+                    .enable_slave_acting_master
+                    .then_some(this.broker_config.broker_not_active_timeout_millis),
+                Default::default(), //optimize
                 this.clone(),
             )
             .await;

diff --git a/rocketmq-common/src/common/broker/broker_config.rs b/rocketmq-common/src/common/broker/broker_config.rs
@@ -197,6 +197,8 @@ pub struct BrokerConfig {
     pub revive_scan_time: u64,
     pub enable_skip_long_awaiting_ack: bool,
     pub skip_when_ck_re_put_reach_max_times: bool,
+    pub compressed_register: bool,
+    pub broker_not_active_timeout_millis: i64,
 }
 
 impl Default for BrokerConfig {
@@ -299,6 +301,8 @@ impl Default for BrokerConfig {
             revive_scan_time: 10_000,
             enable_skip_long_awaiting_ack: false,
             skip_when_ck_re_put_reach_max_times: false,
+            compressed_register: false,
+            broker_not_active_timeout_millis: 10_000,
         }
     }
 }