[ISSUE #2526] Remove ConsumerManageProcessor unused code (#2529)

mxsm · Feb 6, 2025 · c256b2c · c256b2c
1 parent 4789c5a
commit c256b2c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 34 deletions.
diff --git a/rocketmq-broker/src/broker_runtime.rs b/rocketmq-broker/src/broker_runtime.rs
@@ -607,16 +607,7 @@ impl BrokerRuntime {
             self.inner.clone(),
         ));
 
-        let consumer_manage_processor = ConsumerManageProcessor::new(
-            /*self.broker_config.clone(),
-            self.consumer_manager.clone(),
-            self.topic_queue_mapping_manager.clone(),
-            self.subscription_group_manager.clone(),
-            Arc::new(self.consumer_offset_manager.clone()),
-            Arc::new(self.topic_config_manager.clone()),
-            self.message_store.clone().unwrap(),*/
-            self.inner.clone(),
-        );
+        let consumer_manage_processor = ConsumerManageProcessor::new(self.inner.clone());
         self.inner.pull_request_hold_service = Some(PullRequestHoldService::new(
             /* message_store.clone(), */
             pull_message_processor.clone(),

diff --git a/rocketmq-broker/src/processor/consumer_manage_processor.rs b/rocketmq-broker/src/processor/consumer_manage_processor.rs
@@ -36,38 +36,15 @@ use tracing::warn;
 use crate::broker_runtime::BrokerRuntimeInner;
 
 pub struct ConsumerManageProcessor<MS> {
-    /*broker_config: Arc<BrokerConfig>,
-    consumer_manager: Arc<ConsumerManager>,
-    topic_queue_mapping_manager: Arc<TopicQueueMappingManager>,
-    consumer_offset_manager: Arc<ConsumerOffsetManager>,
-    subscription_group_manager: Arc<SubscriptionGroupManager<MS>>,
-    topic_config_manager: Arc<TopicConfigManager>,
-    message_store: ArcMut<MS>,*/
     broker_runtime_inner: ArcMut<BrokerRuntimeInner<MS>>,
 }
 
 impl<MS> ConsumerManageProcessor<MS>
 where
     MS: MessageStore,
 {
-    pub fn new(
-        /*broker_config: Arc<BrokerConfig>,
-        consumer_manager: Arc<ConsumerManager>,
-        topic_queue_mapping_manager: Arc<TopicQueueMappingManager>,
-        subscription_group_manager: Arc<SubscriptionGroupManager<MS>>,
-        consumer_offset_manager: Arc<ConsumerOffsetManager>,
-        topic_config_manager: Arc<TopicConfigManager>,
-        message_store: ArcMut<MS>,*/
-        broker_runtime_inner: ArcMut<BrokerRuntimeInner<MS>>,
-    ) -> Self {
+    pub fn new(broker_runtime_inner: ArcMut<BrokerRuntimeInner<MS>>) -> Self {
         Self {
-            /*broker_config,
-            consumer_manager,
-            topic_queue_mapping_manager,
-            consumer_offset_manager,
-            subscription_group_manager,
-            topic_config_manager,
-            message_store,*/
             broker_runtime_inner,
         }
     }