Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Refactor♻️]FromMap trait from mehtod return type changed from Option<Self::Target> to Result<Self::Target,Self::Error> #1470

Closed
5 tasks
mxsm opened this issue Nov 30, 2024 · 0 comments · Fixed by #1473
Labels
refactor♻️ refactor code
Milestone

Comments

@mxsm
Copy link
Owner

mxsm commented Nov 30, 2024

Which part of the code will be refactored?

No response

What problems does the refactor aim to solve?

No response

Do you have any specific design or implementation considerations?

No response

Is there a related issue or PR?

No response

Checklist

  • Ensure the refactor does not introduce new bugs

  • Update unit tests if applicable

  • Ensure the refactor does not negatively impact performance

  • Document any new patterns or architecture changes

  • Test the refactor in different environments (e.g., staging, production)

@mxsm mxsm added the refactor♻️ refactor code label Nov 30, 2024
@rocketmq-rust-robot rocketmq-rust-robot added this to the v0.4.0 milestone Nov 30, 2024
mxsm added a commit that referenced this issue Nov 30, 2024
…ion<Self::Target> to Result<Self::Target,Self::Error>🚀
rocketmq-rust-bot pushed a commit that referenced this issue Nov 30, 2024
…ion<Self::Target> to Result<Self::Target,Self::Error>🚀 (#1473)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactor♻️ refactor code
Projects
None yet
2 participants