-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[ISSUE #1228]🚀Implement Java MessageDecoder class encodeUniquely and encode method #1229
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request involve modifications to various components of the RocketMQ client and common libraries, primarily focusing on message compression and encoding functionalities. Key updates include the adjustment of method signatures to use Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
Warning Rate limit exceeded@rocketmq-rust-bot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
🔊@mxsm 🚀Thanks for your contribution 🎉. CodeRabbit(AI) will review your code first 🔥 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1229 +/- ##
==========================================
+ Coverage 17.54% 17.94% +0.39%
==========================================
Files 427 427
Lines 53021 53297 +276
==========================================
+ Hits 9305 9563 +258
- Misses 43716 43734 +18 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Which Issue(s) This PR Fixes(Closes)
Fixes #1228
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
Release Notes
New Features
encode
andencode_uniquely
) forMessageExt
instances, with optional compression.Improvements
Bytes
, enhancing efficiency and compatibility.Bug Fixes
Tests