Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #1510]♻️Refactor GetBrokerMemberGroupRequestHeader with derive marco RequestHeaderCodec #1518

Merged
merged 1 commit into from
Dec 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions rocketmq-remoting/src/protocol/header/namesrv/broker_request.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
use std::collections::HashMap;

use cheetah_string::CheetahString;
use rocketmq_macros::RequestHeaderCodec;
use serde::Deserialize;
use serde::Serialize;

Expand Down Expand Up @@ -252,16 +253,18 @@
}
}

#[derive(Debug, Clone, Deserialize, Serialize, Default)]
#[derive(Debug, Clone, Deserialize, Serialize, Default, RequestHeaderCodec)]

Check warning on line 256 in rocketmq-remoting/src/protocol/header/namesrv/broker_request.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-remoting/src/protocol/header/namesrv/broker_request.rs#L256

Added line #L256 was not covered by tests
#[serde(rename_all = "camelCase")]
pub struct GetBrokerMemberGroupRequestHeader {
#[required]
pub cluster_name: CheetahString,
#[required]
pub broker_name: CheetahString,
}

impl GetBrokerMemberGroupRequestHeader {
const BROKER_NAME: &'static str = "brokerName";
const CLUSTER_NAME: &'static str = "clusterName";
/* const BROKER_NAME: &'static str = "brokerName";
const CLUSTER_NAME: &'static str = "clusterName";*/

pub fn new(
cluster_name: impl Into<CheetahString>,
Expand All @@ -275,7 +278,7 @@
}
}

impl CommandCustomHeader for GetBrokerMemberGroupRequestHeader {
/*impl CommandCustomHeader for GetBrokerMemberGroupRequestHeader {
fn to_map(&self) -> Option<HashMap<CheetahString, CheetahString>> {
Some(HashMap::from([
(
Expand Down Expand Up @@ -307,4 +310,33 @@
.unwrap_or_default(),
})
}
}*/

#[cfg(test)]
mod tests {
use cheetah_string::CheetahString;

use super::*;

#[test]
fn new_creates_instance_with_correct_values() {
let header = GetBrokerMemberGroupRequestHeader::new("testCluster", "testBroker");
assert_eq!(header.cluster_name, CheetahString::from("testCluster"));
assert_eq!(header.broker_name, CheetahString::from("testBroker"));
}

#[test]
fn new_creates_instance_with_empty_values() {
let header = GetBrokerMemberGroupRequestHeader::new("", "");
assert_eq!(header.cluster_name, CheetahString::from(""));
assert_eq!(header.broker_name, CheetahString::from(""));
}

#[test]
fn new_creates_instance_with_long_values() {
let long_string = "a".repeat(1000);
let header = GetBrokerMemberGroupRequestHeader::new(&long_string, &long_string);
assert_eq!(header.cluster_name, CheetahString::from(&long_string));
assert_eq!(header.broker_name, CheetahString::from(&long_string));
}
}
Loading