Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #2087]🐛Fix ReferenceResource#hold not correct #2088

Merged
merged 1 commit into from
Jan 4, 2025
Merged

[ISSUE #2087]🐛Fix ReferenceResource#hold not correct #2088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,10 +809,10 @@
#[inline]
pub fn hold(&self) -> bool {
if self.is_available() {
if self.ref_count.fetch_add(1, Ordering::Relaxed) + 1 > 0 {
if self.ref_count.fetch_add(1, Ordering::SeqCst) > 0 {

Check warning on line 812 in rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs#L812 

Added line #L812 was not covered by tests
return true;
} else {
self.ref_count.fetch_sub(1, Ordering::Relaxed);
self.ref_count.fetch_sub(1, Ordering::SeqCst);

Check warning on line 815 in rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-store/src/log_file/mapped_file/default_mapped_file_impl.rs#L815 

Added line #L815 was not covered by tests
}
}
false
Expand Down
Loading