Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #2526] Remove ConsumerManageProcessor unused code #2529

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions rocketmq-broker/src/broker_runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -607,16 +607,7 @@
self.inner.clone(),
));

let consumer_manage_processor = ConsumerManageProcessor::new(
/*self.broker_config.clone(),
self.consumer_manager.clone(),
self.topic_queue_mapping_manager.clone(),
self.subscription_group_manager.clone(),
Arc::new(self.consumer_offset_manager.clone()),
Arc::new(self.topic_config_manager.clone()),
self.message_store.clone().unwrap(),*/
self.inner.clone(),
);
let consumer_manage_processor = ConsumerManageProcessor::new(self.inner.clone());

Check warning on line 610 in rocketmq-broker/src/broker_runtime.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/broker_runtime.rs#L610

Added line #L610 was not covered by tests
self.inner.pull_request_hold_service = Some(PullRequestHoldService::new(
/* message_store.clone(), */
pull_message_processor.clone(),
Expand Down
25 changes: 1 addition & 24 deletions rocketmq-broker/src/processor/consumer_manage_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,38 +36,15 @@
use crate::broker_runtime::BrokerRuntimeInner;

pub struct ConsumerManageProcessor<MS> {
/*broker_config: Arc<BrokerConfig>,
consumer_manager: Arc<ConsumerManager>,
topic_queue_mapping_manager: Arc<TopicQueueMappingManager>,
consumer_offset_manager: Arc<ConsumerOffsetManager>,
subscription_group_manager: Arc<SubscriptionGroupManager<MS>>,
topic_config_manager: Arc<TopicConfigManager>,
message_store: ArcMut<MS>,*/
broker_runtime_inner: ArcMut<BrokerRuntimeInner<MS>>,
}

impl<MS> ConsumerManageProcessor<MS>
where
MS: MessageStore,
{
pub fn new(
/*broker_config: Arc<BrokerConfig>,
consumer_manager: Arc<ConsumerManager>,
topic_queue_mapping_manager: Arc<TopicQueueMappingManager>,
subscription_group_manager: Arc<SubscriptionGroupManager<MS>>,
consumer_offset_manager: Arc<ConsumerOffsetManager>,
topic_config_manager: Arc<TopicConfigManager>,
message_store: ArcMut<MS>,*/
broker_runtime_inner: ArcMut<BrokerRuntimeInner<MS>>,
) -> Self {
pub fn new(broker_runtime_inner: ArcMut<BrokerRuntimeInner<MS>>) -> Self {

Check warning on line 46 in rocketmq-broker/src/processor/consumer_manage_processor.rs

View check run for this annotation

Codecov / codecov/patch

rocketmq-broker/src/processor/consumer_manage_processor.rs#L46

Added line #L46 was not covered by tests
Self {
/*broker_config,
consumer_manager,
topic_queue_mapping_manager,
consumer_offset_manager,
subscription_group_manager,
topic_config_manager,
message_store,*/
broker_runtime_inner,
}
}
Expand Down
Loading