Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[ISSUE #988]🐛Fix rebalance_by_topic method bug in RebalanceImpl🔥 #989

Merged
merged 1 commit into from
Sep 23, 2024
+4 −3
Merged

[ISSUE #988]🐛Fix rebalance_by_topic method bug in RebalanceImpl🔥 #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ where
}
MessageModel::Clustering => {
let topic_sub_cloned = self.topic_subscribe_info_table.clone();
let topic_subscribe_info_table_inner = topic_sub_cloned.write().await;
let topic_subscribe_info_table_inner = topic_sub_cloned.read().await;
let mq_set = topic_subscribe_info_table_inner.get(topic);
//get consumer id list from broker
let cid_all = self
Expand All @@ -296,7 +296,7 @@ where
.unwrap()
.find_consumer_id_list(topic, self.consumer_group.as_ref().unwrap())
.await;
if cid_all.is_none() && !topic.starts_with(mix_all::RETRY_GROUP_TOPIC_PREFIX) {
if mq_set.is_none() && !topic.starts_with(mix_all::RETRY_GROUP_TOPIC_PREFIX) {
if let Some(mut sub_rebalance_impl) =
self.sub_rebalance_impl.as_ref().unwrap().upgrade()
{
Expand All @@ -312,10 +312,11 @@ where
}
if cid_all.is_none() {
warn!(
"doRebalance, {}, but the topic[{}] not exist.",
"doRebalance, {}, {}, get consumer id list failed.",
self.consumer_group.as_ref().unwrap(),
topic
);
return true;
}
if mq_set.is_some() && cid_all.is_some() {
let mq_set = mq_set.unwrap();
Expand Down
Loading