Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Basic translations #162

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Basic translations #162

wants to merge 4 commits into from

Conversation

silent1mezzo
Copy link
Contributor

Just started the boilerplate for translating the site. Currently Header/Footer and Tagline can be translated. Will add the main parts of a story and the form.

@vercel
Copy link

vercel bot commented May 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/my-covid-story/www/C6yhWP2YLhjrQC9d6utZaHe2sH7x
✅ Preview: https://www-git-amtranslate-my-covid-story.vercel.app

@silent1mezzo
Copy link
Contributor Author

silent1mezzo commented May 3, 2021

📝Changed routes:

/
Screenshot of /
(view full size)

Commit d0b4b4a (https://www-7k3l773fn-my-covid-story.vercel.app).

@silent1mezzo
Copy link
Contributor Author

silent1mezzo commented May 3, 2021

This will eventually fix #107

@LuckeeDev
Copy link
Contributor

LuckeeDev commented May 3, 2021

Isn't this related to #107 more than #106 @silent1mezzo?

@silent1mezzo
Copy link
Contributor Author

Good catch @LuckeeDev

Copy link
Collaborator

@davesteinberg davesteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem here is that there's text coming from stories/model.js, and that's not getting translated. So, I think that needs to be reworked a bit to do the translation itself. I've created PR #172 against this branch to suggest an approach: The functions from model.js that require translation are replaced by a custom useLabels() hook that can do the translation. I've also renamed model.js to utils.js, as I've been meaning to for a while, since it no longer defines the model.

I've also included a couple of other suggested changes in that PR (I've added comments there to point them out). What do you think?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants