Add meaningful device info. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds device information which shows up in the device page in Home Assistant, including a link to each sensor's configuration page at pixometer.io.
This configuration page of the the pixometer.io portal allows to set labels ("Kurzbezeichnung") for each sensor. While these labels don't show up in the free Android app, they do show up in the API.
If available, this PR uses these labels as the device name. If no labels have been set, this PR will fall back to the previous naming scheme based on the location (which is the only attribute show in the free Android app).
For the individual sensor entities, this PR changes the naming to meet Home Assistant requirements, which will result in the entity's name to be equal to the device's name:
https://developers.home-assistant.io/docs/core/entity/#has_entity_name-true-mandatory-for-new-integrations
This implementation is backwards-compatible: if you are not using labels, the implementation will give the same name as before. If you use a label, it will use that instead.