Output warning when deserializing object stream #2079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have received another security vulnerability report caused by object stream deserialization.
When all of the following conditions are met, the attacker can trigger RCE (remote code execution).
Map
field i.e.org.apache.ibatis.cache.impl.PerpetualCache.cache
and a valid cache keyWe thank clanceyzzz of JD Sprite Team for reporting the issue!
Once this PR gets merged, MyBatis outputs WARN level log message when deserializing object.
Note that:
If WARN message is not enough, we can throw an exception instead, but that may surprise users a little bit.
[1] Some of the custom cache implementations also perform deserialization (e.g. mybatis-redis-cache). I plan to look into it later, but the recommended solution is the same i.e. the JEP-290 filter.