Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Class proxy #165

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Class proxy #165

wants to merge 1 commit into from

Conversation

daycry
Copy link

@daycry daycry commented Aug 4, 2021

The proxy class in doctrine is different

The proxy class in doctrine is different
@sstutz
Copy link

sstutz commented Aug 25, 2021

+1 this change is needed in order to make DeepCopy work with recent releases of doctrine.

@mnapoli
Copy link
Member

mnapoli commented Aug 26, 2021

Thanks. Ideally we should support both versions, here I guess it will break backward compatibility.

@daycry
Copy link
Author

daycry commented Aug 26, 2021

Hello, I understand you, but a lot of people upgrade doctrine version for improve our features like me.

I only want help us but is your Code.

Thank you for your answers.

@sstutz
Copy link

sstutz commented Aug 26, 2021

then change was introduced in v2 https://github.com/doctrine/persistence/blob/3.0.x/UPGRADE-2.0.md
so I guess we could do something like

if (persistence >= v2) { $obj instanceof Proxy } else { $obj instanceof Common\Proxy }

@mnapoli thoughts?

@mnapoli
Copy link
Member

mnapoli commented Aug 26, 2021

No particular thoughts, I don't know if that would work by just looking at this example to be honest. Feel free to test/investigate, I won't have time to invest into this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants