Skip to content

Commit

Permalink
feat: Return scopes on executions (no-changelog) (#10310)
Browse files Browse the repository at this point in the history
  • Loading branch information
valya authored Aug 7, 2024
1 parent 6d8323f commit fa17391
Show file tree
Hide file tree
Showing 10 changed files with 94 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,12 @@ export class ProjectRelationRepository extends Repository<ProjectRelation> {

return [...new Set(rows.map((r) => r.userId))];
}

async findAllByUser(userId: string) {
return await this.find({
where: {
userId,
},
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,13 @@ export class SharedWorkflowRepository extends Repository<SharedWorkflow> {
})
)?.project;
}

async getRelationsByWorkflowIdsAndProjectIds(workflowIds: string[], projectIds: string[]) {
return await this.find({
where: {
workflowId: In(workflowIds),
projectId: In(projectIds),
},
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ describe('ExecutionService', () => {
mock(),
concurrencyControl,
mock(),
mock(),
);

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ describe('ExecutionsController', () => {
},
];

executionService.findRangeWithCount.mockResolvedValue(NO_EXECUTIONS);

describe('if either status or range provided', () => {
test.each(QUERIES_WITH_EITHER_STATUS_OR_RANGE)(
'should fetch executions per query',
Expand Down
15 changes: 15 additions & 0 deletions packages/cli/src/executions/execution.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ import { QueuedExecutionRetryError } from '@/errors/queued-execution-retry.error
import { ConcurrencyControlService } from '@/concurrency/concurrency-control.service';
import { AbortedExecutionRetryError } from '@/errors/aborted-execution-retry.error';
import { License } from '@/License';
import type { User } from '@/databases/entities/User';
import { WorkflowSharingService } from '@/workflows/workflowSharing.service';

export const schemaGetExecutionsQueryFilter = {
$id: '/IGetExecutionsQueryFilter',
Expand Down Expand Up @@ -92,6 +94,7 @@ export class ExecutionService {
private readonly workflowRunner: WorkflowRunner,
private readonly concurrencyControl: ConcurrencyControlService,
private readonly license: License,
private readonly workflowSharingService: WorkflowSharingService,
) {}

async findOne(
Expand Down Expand Up @@ -478,4 +481,16 @@ export class ExecutionService {

return await this.executionRepository.stopDuringRun(execution);
}

async addScopes(user: User, summaries: ExecutionSummaries.ExecutionSummaryWithScopes[]) {
const workflowIds = [...new Set(summaries.map((s) => s.workflowId))];

const scopes = Object.fromEntries(
await this.workflowSharingService.getSharedWorkflowScopes(workflowIds, user),
);

for (const s of summaries) {
s.scopes = scopes[s.workflowId] ?? [];
}
}
}
10 changes: 9 additions & 1 deletion packages/cli/src/executions/execution.types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import type { ExecutionEntity } from '@/databases/entities/ExecutionEntity';
import type { AuthenticatedRequest } from '@/requests';
import type { ExecutionStatus, IDataObject, WorkflowExecuteMode } from 'n8n-workflow';
import type { Scope } from '@n8n/permissions';
import type {
ExecutionStatus,
ExecutionSummary,
IDataObject,
WorkflowExecuteMode,
} from 'n8n-workflow';

export declare namespace ExecutionRequest {
namespace QueryParams {
Expand Down Expand Up @@ -83,6 +89,8 @@ export namespace ExecutionSummaries {
stoppedAt?: 'DESC';
};
};

export type ExecutionSummaryWithScopes = ExecutionSummary & { scopes: Scope[] };
}

export type QueueRecoverySettings = {
Expand Down
16 changes: 13 additions & 3 deletions packages/cli/src/executions/executions.controller.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ExecutionRequest } from './execution.types';
import { ExecutionRequest, type ExecutionSummaries } from './execution.types';
import { ExecutionService } from './execution.service';
import { Get, Post, RestController } from '@/decorators';
import { EnterpriseExecutionsService } from './execution.service.ee';
Expand Down Expand Up @@ -53,10 +53,20 @@ export class ExecutionsController {
const noRange = !query.range.lastId || !query.range.firstId;

if (noStatus && noRange) {
return await this.executionService.findLatestCurrentAndCompleted(query);
const executions = await this.executionService.findLatestCurrentAndCompleted(query);
await this.executionService.addScopes(
req.user,
executions.results as ExecutionSummaries.ExecutionSummaryWithScopes[],
);
return executions;
}

return await this.executionService.findRangeWithCount(query);
const executions = await this.executionService.findRangeWithCount(query);
await this.executionService.addScopes(
req.user,
executions.results as ExecutionSummaries.ExecutionSummaryWithScopes[],
);
return executions;
}

@Get('/:id')
Expand Down
26 changes: 26 additions & 0 deletions packages/cli/src/workflows/workflowSharing.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ import { RoleService } from '@/services/role.service';
import type { Scope } from '@n8n/permissions';
import type { ProjectRole } from '@/databases/entities/ProjectRelation';
import type { WorkflowSharingRole } from '@/databases/entities/SharedWorkflow';
import { ProjectRelationRepository } from '@/databases/repositories/projectRelation.repository';

@Service()
export class WorkflowSharingService {
constructor(
private readonly sharedWorkflowRepository: SharedWorkflowRepository,
private readonly roleService: RoleService,
private readonly projectRelationRepository: ProjectRelationRepository,
) {}

/**
Expand Down Expand Up @@ -64,4 +66,28 @@ export class WorkflowSharingService {

return sharedWorkflows.map(({ workflowId }) => workflowId);
}

async getSharedWorkflowScopes(
workflowIds: string[],
user: User,
): Promise<Array<[string, Scope[]]>> {
const projectRelations = await this.projectRelationRepository.findAllByUser(user.id);
const sharedWorkflows =
await this.sharedWorkflowRepository.getRelationsByWorkflowIdsAndProjectIds(
workflowIds,
projectRelations.map((p) => p.projectId),
);

return workflowIds.map((workflowId) => {
return [
workflowId,
this.roleService.combineResourceScopes(
'workflow',
user,
sharedWorkflows.filter((s) => s.workflowId === workflowId),
projectRelations,
),
];
});
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ describe('ExecutionService', () => {
mock(),
mock(),
mock(),
mock(),
);
});

Expand Down
10 changes: 10 additions & 0 deletions packages/cli/test/integration/executions.controller.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@ describe('GET /executions', () => {
const response2 = await testServer.authAgentFor(member).get('/executions').expect(200);
expect(response2.body.data.count).toBe(1);
});

test('should return a scopes array for each execution', async () => {
testServer.license.enable('feat:sharing');
const workflow = await createWorkflow({}, owner);
await shareWorkflowWithUsers(workflow, [member]);
await createSuccessfulExecution(workflow);

const response = await testServer.authAgentFor(member).get('/executions').expect(200);
expect(response.body.data.results[0].scopes).toContain('workflow:execute');
});
});

describe('GET /executions/:id', () => {
Expand Down

0 comments on commit fa17391

Please # to comment.