feat(n8n Form Trigger Node): Improvements #10092

michael-radency · 2024-07-18T07:08:30Z

Summary

Basic Authentication
Placeholders
Query params as defaults in form
Ignore bots option
Format date
Email field type
File field type
Required fields marked with *
Description supports line breaks (\n, <br>)
Fixed submittedAt property to be in workflow timezone
Improved small screens view
Various styles fixes

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1505/form-trigger-improvements-p1
https://community.n8n.io/t/n8n-form-trigger-upload-files-type-field/32495/5
https://community.n8n.io/t/timezone-ignored-in-webform-submittedat-time/46685/10
https://community.n8n.io/t/n8n-form-size/34877

…form-trigger-improvements-p1

packages/nodes-base/nodes/Form/utils.ts

…form-trigger-improvements-p1

packages/nodes-base/nodes/Form/utils.ts

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>

…form-trigger-improvements-p1

netroy

From a quick glance, this LGTM.
quite a lot of nice improvements 👏🏽 .

Maybe @elsmr or @ShireenMissi can also review this

…form-trigger-improvements-p1

michael-radency · 2024-07-19T09:47:25Z

From a quick glance, this LGTM. quite a lot of nice improvements 👏🏽 .

Maybe @elsmr or @ShireenMissi can also review this

thanks @netroy , some changes would need a review from product though

netroy · 2024-07-19T09:57:00Z

packages/nodes-base/nodes/Webhook/utils.ts

@@ -167,3 +176,96 @@ export const checkResponseModeConfiguration = (context: IWebhookFunctions) => {
 		);
 	}
 };
+
+export async function validateWebhookAuthentication(


BTW, since this so neatly extracted out now, it might be possible to write unit tests for this. If we can add these tests in the same PR, that's be nice, otherwise I can also try to create a PR with just the tests later 🙏🏽

ShireenMissi

Mostly looks good 👍
I have the following comments on multi file select field:

it seems the files are cleared every time one clicks choose file.
there is no way to select files from multiple locations

Also please add some tests

…form-trigger-improvements-p1

michael-radency · 2024-07-25T07:39:21Z

it seems the files are cleared every time one clicks choose file.

there is no way to select files from multiple locations

@ShireenMissi
This is how file selectors usually operate. We could preserve selected files and support appending new ones, but in such a case, we would need a mechanism to clear the input. So, while this could be implemented, it would require custom code and styling, which means an increased scope.

…form-trigger-improvements-p1

…put button

packages/cli/templates/form-trigger.handlebars

ShireenMissi · 2024-07-29T10:34:11Z

it seems the files are cleared every time one clicks choose file.

there is no way to select files from multiple locations

@ShireenMissi This is how file selectors usually operate. We could preserve selected files and support appending new ones, but in such a case, we would need a mechanism to clear the input. So, while this could be implemented, it would require custom code and styling, which means an increased scope.

Thanks @michael-radency we can always improve it in next versions, I am happy with the changes you made to the file field👍

Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>

…form-trigger-improvements-p1

ShireenMissi

LGTM 🎉

github-actions · 2024-07-29T12:51:27Z

✅ All Cypress E2E specs passed

cypress · 2024-07-29T12:51:27Z

Passing run #6179 ↗︎

0	389	0	0	0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n	Commit: `c2c33db04c`
Status: Passed	Duration: 04:12 💡
Started: Jul 29, 2024 12:47 PM	Ended: Jul 29, 2024 12:51 PM

Review all test suite changes for PR #10092 ↗︎

* master: docs: Update login url for OpenAI node (no-changelog) (#10222) fix(LinkedIn Node): Fix issue with some characters cutting off posts early (#10185) fix(Google BigQuery Node): Send timeoutMs in query, pagination support (#10205) feat(core): Show Public API key value only once (no-changelog) (#10126) refactor(core): Display stack trace in error reporter (no-changelog) (#10225) fix(core): Fix missing successful items on continueErrorOutput with multiple outputs (#10218) fix(n8n Form Trigger Node): Remove custom attribution option (no-changelog) (#10229) feat(n8n Form Trigger Node): Improvements (#10092) refactor(core): Port path, host, port, listen_address and protocol config (no-changelog) (#10223) docs: Update add options text (no-changelog) (#10049) fix(Postgres Node): Option to treat query parameters enclosed in single quotas as text (#10214) refactor(core): Decouple server started event from internal hooks (no-changelog) (#10221) feat(Shopify Node): Update Shopify API version (#10155) fix(editor): Defer `User saved credentials` telemetry event for OAuth credentials (#10215) fix(editor): Fix parameter input glitch when there was an error loading remote options (#10209)

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com> Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>

janober · 2024-07-31T13:13:39Z

Got released with n8n@1.53.0

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com> Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>

michael-radency added 3 commits July 18, 2024 08:17

styles fixes, timezone fix, email field type, mark mandatory fields

c2fed14

file support

95933e6

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

805c4d9

…form-trigger-improvements-p1

michael-radency added node/improvement New feature or request n8n team Authored by the n8n team node/issue Issue with a node labels Jul 18, 2024

michael-radency added 7 commits July 18, 2024 11:48

multiple files support, accepted file types parameter

58768b9

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

2050a38

…form-trigger-improvements-p1

format date option

2cbec76

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

40a1103

…form-trigger-improvements-p1

query params as defaults, placeholders

99f18b7

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

a3af9ac

…form-trigger-improvements-p1

disable number input update on scroll in firefox

0c09fe8

netroy reviewed Jul 18, 2024

View reviewed changes

packages/nodes-base/nodes/Form/utils.ts Show resolved Hide resolved

michael-radency added 4 commits July 19, 2024 06:55

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

d98abf0

…form-trigger-improvements-p1

basic auth, ignore bots option

806a9db

custom attribution

5958c65

mobile view fix

8b228e9

netroy reviewed Jul 19, 2024

View reviewed changes

packages/nodes-base/nodes/Form/utils.ts Outdated Show resolved Hide resolved

michael-radency and others added 3 commits July 19, 2024 11:49

Update packages/nodes-base/nodes/Form/utils.ts

ea3fada

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

aa592c6

…form-trigger-improvements-p1

prettier fix

42c8b2e

netroy reviewed Jul 19, 2024

View reviewed changes

michael-radency added 2 commits July 19, 2024 12:43

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

0c32d23

…form-trigger-improvements-p1

cleanup

bb51fe4

netroy reviewed Jul 19, 2024

View reviewed changes

ShireenMissi reviewed Jul 24, 2024

View reviewed changes

michael-radency added 2 commits July 25, 2024 04:56

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

67a7fa0

…form-trigger-improvements-p1

review updates

2408bd9

michael-radency added 2 commits July 25, 2024 09:37

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

77ea9f0

…form-trigger-improvements-p1

do not open form on chat trigger message

1255baa

michael-radency added 4 commits July 29, 2024 05:26

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

5c820ac

…form-trigger-improvements-p1

email validation error display update

55c8dd4

tests

bb79c32

restore previously selected files if nothing selected, clear files in…

0b49bcc

…put button

ShireenMissi reviewed Jul 29, 2024

View reviewed changes

packages/cli/templates/form-trigger.handlebars Outdated Show resolved Hide resolved

packages/cli/templates/form-trigger.handlebars Show resolved Hide resolved

packages/cli/templates/form-trigger.handlebars Outdated Show resolved Hide resolved

michael-radency and others added 3 commits July 29, 2024 13:49

Update packages/cli/templates/form-trigger.handlebars

98c771a

Co-authored-by: Shireen Missi <94372015+ShireenMissi@users.noreply.github.com>

Merge branch 'master' of https://github.com/n8n-io/n8n into node-1505-…

8e2b914

…form-trigger-improvements-p1

review update

c2c33db

michael-radency requested a review from ShireenMissi July 29, 2024 12:05

ShireenMissi approved these changes Jul 29, 2024

View reviewed changes

michael-radency merged commit 711b667 into master Jul 29, 2024
27 checks passed

michael-radency deleted the node-1505-form-trigger-improvements-p1 branch July 29, 2024 12:58

github-actions bot mentioned this pull request Jul 31, 2024

🚀 Release 1.53.0 #10266

Merged

janober added the Released label Jul 31, 2024

ayatnkw mentioned this pull request Aug 13, 2024

Docs for: Form trigger improvements P1 n8n-io/n8n-docs#2345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(n8n Form Trigger Node): Improvements #10092

feat(n8n Form Trigger Node): Improvements #10092

michael-radency commented Jul 18, 2024 •

edited

Loading

netroy left a comment

michael-radency commented Jul 19, 2024

netroy Jul 19, 2024

ShireenMissi left a comment

michael-radency commented Jul 25, 2024

ShireenMissi commented Jul 29, 2024

ShireenMissi left a comment

github-actions bot commented Jul 29, 2024

cypress bot commented Jul 29, 2024

janober commented Jul 31, 2024

feat(n8n Form Trigger Node): Improvements #10092

feat(n8n Form Trigger Node): Improvements #10092

Conversation

michael-radency commented Jul 18, 2024 • edited Loading

Summary

Related Linear tickets, Github issues, and Community forum posts

netroy left a comment

Choose a reason for hiding this comment

michael-radency commented Jul 19, 2024

netroy Jul 19, 2024

Choose a reason for hiding this comment

ShireenMissi left a comment

Choose a reason for hiding this comment

michael-radency commented Jul 25, 2024

ShireenMissi commented Jul 29, 2024

ShireenMissi left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 29, 2024

cypress bot commented Jul 29, 2024

Passing run #6179 ↗︎

Review all test suite changes for PR #10092 ↗︎

janober commented Jul 31, 2024

michael-radency commented Jul 18, 2024 •

edited

Loading