Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(HTTP Request Node): Add option to disable lowercase headers #10154

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat(HTTP Request Node): Add option to disable lowercase headers #10154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,13 @@ export class HttpRequestV3 implements INodeType {
],
default: 'brackets',
},
{
displayName: 'Lowercase Headers',
name: 'lowercaseHeaders',
type: 'boolean',
default: true,
description: 'Whether to lowercase header names',
},
{
displayName: 'Redirects',
name: 'redirect',
Expand Down Expand Up @@ -1388,6 +1395,7 @@ export class HttpRequestV3 implements INodeType {
allowUnauthorizedCerts,
queryParameterArrays,
response,
lowercaseHeaders,
} = this.getNodeParameter('options', itemIndex, {}) as {
batching: { batch: { batchSize: number; batchInterval: number } };
proxy: string;
Expand All @@ -1398,6 +1406,7 @@ export class HttpRequestV3 implements INodeType {
response: { neverError: boolean; responseFormat: string; fullResponse: boolean };
};
redirect: { redirect: { maxRedirects: number; followRedirects: boolean } };
lowercaseHeaders: boolean;
};

const url = this.getNodeParameter('url', itemIndex) as string;
Expand Down Expand Up @@ -1611,7 +1620,9 @@ export class HttpRequestV3 implements INodeType {
}
requestOptions.headers = {
...requestOptions.headers,
...keysToLowercase(additionalHeaders),
...(lowercaseHeaders === undefined || lowercaseHeaders
? keysToLowercase(additionalHeaders)
: additionalHeaders),
};
}

Expand Down
Loading