fix(editor): Fix canvas panning using Control + Left Mouse Button on Windows
#12104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgrozav
commented
Dec 9, 2024
| @@ -642,7 +644,7 @@ provide(CanvasKey, { | |||
| @connect="onConnect" | |||
| @connect-end="onConnectEnd" | |||
| @pane-click="onClickPane" | |||
| @contextmenu="onOpenContextMenu" | |||
| @pane-context-menu="onOpenContextMenu" | |||
There was a problem hiding this comment.
New event name after update
alexgrozav
commented
Dec 9, 2024
| @@ -147,10 +147,12 @@ const selectionKeyCode = ref<true | null>(true); | |||
|
|
|||
| onKeyDown(panningKeyCode.value, () => { | |||
| selectionKeyCode.value = null; | |||
| panningMouseButton.value = [0, 1]; | |||
There was a problem hiding this comment.
0 - Left mouse button
1 - Middle mouse button
n8n-assistant
bot
added
n8n team
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
elsmr
approved these changes
Dec 9, 2024
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-339-community-issue-new-canvas-issue-not-able-to-move-canvas-2
|
| Run status |
|
| Run duration | 04m 37s |
| Commit |
|
| Committer | Alex Grozav |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
480
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
alexgrozav
deleted the
cat-339-community-issue-new-canvas-issue-not-able-to-move-canvas-2
branch
Merged
|
Got released with |
alexgrozav
added
the
release/backport
ivov
pushed a commit
that referenced
this pull request
Dec 12, 2024
Merged
ivov
pushed a commit
that referenced
this pull request
Dec 12, 2024
netroy
pushed a commit
that referenced
this pull request
Dec 12, 2024
tomi
pushed a commit
that referenced
this pull request
Dec 12, 2024
Merged
riascho
pushed a commit
that referenced
this pull request
Jan 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screen.Recording.2024-12-09.at.14.29.03.mov
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-339/community-issue-new-canvas-issue-not-able-to-move-canvas-using
#11755
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)