Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(Google Vertex Chat Model Node): Add an option to specify GCP region #12300

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

burivuhster
Copy link
Contributor

Summary

This PR adds an option to choose GCP Region for the Google API credentials. For the moment, the only node affected by this change is the Google Vertex AI Chat Model.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@burivuhster burivuhster force-pushed the ai-365-community-issue-google-vertex-ai-chat-model-node-missing-gcp branch from e02eb0f to 8cd609e Compare December 19, 2024 09:21
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Dec 19, 2024
…at-model-node-missing-gcp

# Conflicts:
#	packages/nodes-base/credentials/GoogleApi.credentials.ts
@burivuhster burivuhster changed the title feat(Google Vertex AI Chat Model Node): Add an option to specify GCP region feat(Google Vertex Chat Model Node): Add an option to specify GCP region Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...llms/LmChatGoogleVertex/LmChatGoogleVertex.node.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@burivuhster burivuhster marked this pull request as ready for review December 20, 2024 11:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant