fix(Postgres Node): Re-use connection pool across executions #12346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
n8n team
despairblue
changed the title
despairblue
force-pushed
the
connection-pooling
branch
from
53a06dd to
68135b8
Compare
netroy
requested changes
Dec 24, 2024
netroy
approved these changes
Dec 24, 2024
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
connection-pooling
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
483
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This add a connection pool manager similar to the ssh SSHClientsManager for re-using ssh connections.
It's a singleton that lives in the nodes-base package. Adi and I initially tried to make this available through the context (node execution functions) and also have this available to the credentials and have them manage the connections, but this led to changes to the interfaces in the workflow package that would have culminated in a single huge refactor in this PR. Instead we chose this simpler approach that can later be integrated into the context and be made available to the credentials instead of the nodes by further refactors.
Next step is to use the manager for more nodes, e.g. MSSQL and MySQL. This will also fix an issue that at least one cloud customer has with connections to MSSQL being blocked because we connect and disconnect too often when they execute the MSSQL node in a tight loop.
Related Linear tickets, Github issues, and Community forum posts
todo: add help ticket link
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)