Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(core): Comply with NO_COLOR in logs #12347

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(core): Comply with NO_COLOR in logs #12347

wants to merge 1 commit into from
+18 −10

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Dec 23, 2024 •
edited
Loading

Summary

Make log coloring dependent on NO_COLOR in prod and dev envs. Already supported on cloud.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2262

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 23, 2024
@ivov ivov mentioned this pull request Dec 23, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/core/src/logging/logger.ts 8.33% 11 Missing ⚠️

📢 Thoughts on this report? Let us know!

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ivov