Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: Updates link to luxon documentation #12352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

riascho
Copy link
Contributor

@riascho riascho commented Dec 23, 2024

Summary

Just a quick fix to update the correct link to our luxon documentation.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 23, 2024

n8n    Run #8465

Run Properties:  status check failed Failed #8465  •  git commit 7be84b7015: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
Project n8n
Branch Review datetime-node-fix-luxon-docs-link
Run status status check failed Failed #8465
Run duration 04m 10s
Commit git commit 7be84b7015: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
Committer Ria
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 377
View all changes introduced in this branch ↗︎

Tests for review

Failed  14-mapping.cy.ts • 1 failed test

View Output Video

Test Artifacts
Data mapping > maps expressions from json view Test Replay Screenshots Video
Failed  233-AI-switch-to-logs-on-error.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  1-workflows.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  21-community-nodes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  42-nps-survey.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 39 specs in Cypress Cloud.

Flakiness  e2e/48-subworkflow-inputs.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Sub-workflow creation and typed usage > works with Fields input source into JSON input source Test Replay Screenshots Video

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

3 similar comments
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@Jesus-is-Lord-1
Copy link

Jesus-is-Lord-1 commented Dec 24, 2024 via email

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants