ci: Upgrade to pnpm 10 #12502
Open
ci: Upgrade to pnpm 10 #12502
+36
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
4 tasks
tomi
reviewed
Feb 7, 2025
| @@ -18,7 +18,7 @@ RUN find . -type f -name "*.ts" -o -name "*.js.map" -o -name "*.vue" -o -name "t | |||
|
|
|||
| # Deploy the `n8n` package into /compiled | |||
| RUN mkdir /compiled | |||
| RUN NODE_ENV=production DOCKER_BUILD=true pnpm --filter=n8n --prod --no-optional deploy /compiled | |||
| RUN NODE_ENV=production DOCKER_BUILD=true pnpm --filter=n8n --prod --no-optional --legacy deploy /compiled | |||
There was a problem hiding this comment.
What does the --legacy do? Can we document that
There was a problem hiding this comment.
TBH, I don't know for sure. All I know is that pnpm 10 changed the default implementation for pnpm deploy which breaks with catalog: dependencies. Using --legacy switched back to the behavior we had on pnpm 9.
There is a discussion here.
I'm hoping that before pnpm 11 I would have made sense of this change, and can remove the flag by then.
There was a problem hiding this comment.
Maybe add the link to the discussion as a comment for future reference
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pnpm 10 was released a month ago.
So far I have not found any regressions in our setup from this upgrade.
Once the CI is green, and if custom docker images work as expected, we can merge this.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)