Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(editor): Fix sending of push messages when connection is down (no-changelog) #13133

Merged

Conversation

tomi
Copy link
Collaborator

@tomi tomi commented Feb 7, 2025

Summary

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@tomi tomi changed the title fix(editor): invalid union discriminator error shown when stopping fix(editor): invalid union discriminator error shown when stopping (no-changelog) Feb 7, 2025
@tomi tomi changed the title fix(editor): invalid union discriminator error shown when stopping (no-changelog) fix(editor): Invalid union discriminator error shown when stopping (no-changelog) Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Feb 7, 2025
@tomi tomi requested a review from michael-radency February 7, 2025 16:16
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Feb 10, 2025

n8n    Run #9202

Run Properties:  status check passed Passed #9202  •  git commit b0a8f5b4ab: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Project n8n
Branch Review cat-629-invalid_union_discriminator-error-shown-when-stopping
Run status status check passed Passed #9202
Run duration 04m 36s
Commit git commit b0a8f5b4ab: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 tomi 🗃️ e2e/*
Committer Tomi Turtiainen
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 434
View all changes introduced in this branch ↗︎

@tomi tomi changed the title fix(editor): Invalid union discriminator error shown when stopping (no-changelog) fix(editor): Fix sending of push messages when connection is down (no-changelog) Feb 10, 2025
@tomi tomi merged commit da837fe into master Feb 10, 2025
38 of 39 checks passed
@tomi tomi deleted the cat-629-invalid_union_discriminator-error-shown-when-stopping branch February 10, 2025 08:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants