fix(core): Run full manual execution when a trigger is executed even if run data exists #13194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
despairblue
force-pushed
the
pay-1998-clicking-run-on-a-trigger-produces-an-error
branch
from
265b2c7 to
b59274c
Compare
n8n-assistant
bot
added
core
despairblue
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
despairblue
force-pushed
the
pay-1998-clicking-run-on-a-trigger-produces-an-error
branch
2 times, most recently
from
26a73c4 to
c2247d3
Compare
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
pay-1998-clicking-run-on-a-trigger-produces-an-error
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | Danny Martini |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
436
|
| View all changes introduced in this branch ↗︎ | |
tomi
reviewed
Feb 13, 2025
...xecution-engine/partial-execution-utils/__tests__/find-trigger-for-partial-execution.test.ts
Outdated
Show resolved
Hide resolved
despairblue
force-pushed
the
pay-1998-clicking-run-on-a-trigger-produces-an-error
branch
from
c2247d3 to
57f28f2
Compare
|
|
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-1998-clicking-run-on-a-trigger-produces-an-error
branch
Merged
|
Got released with |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run a full manual execution when a trigger is executed even if run data exists. Before it would try to run a partial execution which is not possible in that case.
Doing this as a partial execution is not possible, because running the trigger will remove all run data from the trigger and all it's children, thus turning this into a full execution.
If the trigger is a webhook trigger we need to activate it and listen for incoming data. If we are in the partial execution logic we can't do that anymore as we are too deep down to go back and register the webhook.
That's why we check in the
WorkflowExecutionServiceif the destination node is a trigger. If that is the case we remove the run data and thus force the full manual execution flow.This is a bit of a workaround until we have decided how to structure this better, probably running the partial execution logic first (before creating the execution in the db) to find out if we can run this partially or if we need to check what trigger to use and if we need to wait for a webhook.
Before
PAY-1998-before.mp4
After
PAY-1998-after.mp4
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1998/clicking-run-on-a-trigger-produces-an-error
Review / Merge checklist
Docs updated or follow-up ticket created.PR Labeled withrelease/backport(if the PR is an urgent fix that needs to be backported)