fix: Always clear popupWindowState before showing popup from form trigger #13363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if-you-close-the-form-trigger-pop-up-window-without
michael-radency
added
ui
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
|
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-2413-if-you-close-the-form-trigger-pop-up-window-without
|
| Run status |
|
| Run duration | 04m 40s |
| Commit |
|
| Committer | Michael Kret |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
…if-you-close-the-form-trigger-pop-up-window-without
ShireenMissi
approved these changes
Feb 19, 2025
ShireenMissi
added
tests-needed
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-2413-if-you-close-the-form-trigger-pop-up-window-without
branch
tomi
pushed a commit
that referenced
this pull request
Feb 20, 2025
Merged
tomi
pushed a commit
that referenced
this pull request
Feb 20, 2025
Merged
|
Got released with |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Always clear popupWindowState before showing popup from form trigger
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2413/if-you-close-the-form-trigger-pop-up-window-without-completing-it-it
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)