Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core): Tweaks for Some AI nodes (no-changelog) #7774

Merged
merged 25 commits into from
Nov 28, 2023
Merged

fix(core): Tweaks for Some AI nodes (no-changelog) #7774

merged 25 commits into from
Nov 28, 2023

Conversation

michael-radency
Copy link
Contributor

@michael-radency michael-radency commented Nov 22, 2023 •
edited by OlegIvaniv
Loading

  • Tweak the format of the info boxes in nodes that are shown at the top of sub-nodes when they’re not connected
  • In nodes that are chat compatible, rename the default expression in the prompt param from $json.input to $json.chat_input
  • When executing a manual chat trigger and there’s no chain executed, improve the error text
  • Better Vector Store error messages
  • Improve window buffer memory description
  • Use RLC every time we’re loading a list from an API for:
    • OpenAI model (’model’ param)
    • OpenAI embedding (’model’ param)
    • Pinecone vector store
  • Improve window buffer memory description
  • Add an info box to auto-fixing output parser
  • Change wording of the output pane of sub-node when there’s no execution, and remove the link there. Plus remove the edit button

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added the n8n team Authored by the n8n team label Nov 22, 2023
OlegIvaniv
OlegIvaniv reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but can you please check why the pipeline is failing? 🙏

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Nov 28, 2023 •
edited
Loading

1 flaky test on run #3071 ↗︎

0 295 5 0 Flakiness 1

Details:

🌳 node-939-ai-node-tweaks 🖥️ browsers:node18.12.0-chrome107 🤖 oleg 🗃️ e2e/*
Project: n8n Commit: 488bf3c3e4
Status: Passed Duration: 06:38 💡
Started: Nov 28, 2023 11:33 AM Ended: Nov 28, 2023 11:40 AM
Flakiness  cypress/e2e/15-scheduler-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Schedule Trigger node > should execute once per second when activated Screenshots Video

Review all test suite changes for PR #7774 ↗︎

@OlegIvaniv
🐛 Differentiate between sub-node runNodeHint
6d36bab 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@OlegIvaniv
⏪️ Revert d95599a RunData changes
435cfff 
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy changed the title fix(core): Tweaks (no-changelog) fix(core): Tweaks for Some AI nodes (no-changelog) Nov 28, 2023
@netroy netroy merged commit 1edd0fd into ai-beta Nov 28, 2023
@netroy netroy deleted the node-939-ai-node-tweaks branch November 28, 2023 12:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-radency @OlegIvaniv @netroy