Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(core): Fix expression evaluator filename typo (no-changelog) #7960

Merged
merged 1 commit into from
Dec 7, 2023
Merged

fix(core): Fix expression evaluator filename typo (no-changelog) #7960

merged 1 commit into from
Dec 7, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Dec 7, 2023

Summary

Provide details about your pull request and what it adds, fixes, or changes. Photos and videos are recommended.

...

How to test the change:

  1. ...

Issues fixed

Include links to Github issue or Community forum post or Linear ticket:

Important in order to close automatically and provide context to reviewers

...

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

    (internal) You can use Slack commands to trigger e2e tests or deploy test instance or deploy early access version on Cloud.

valya
valya approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@valya valya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did I never notice this?

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 7, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress Cypress
Copy link

cypress bot commented Dec 7, 2023 •
edited
Loading

Passing run #3244 ↗︎

0 297 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 907a77e419
Status: Passed Duration: 06:21 💡
Started: Dec 7, 2023 4:35 PM Ended: Dec 7, 2023 4:42 PM

Review all test suite changes for PR #7960 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

✅ All Cypress E2E specs passed

@ivov ivov merged commit c48850d into master Dec 7, 2023
16 checks passed
@ivov ivov deleted the fix-expression-evaluator-filename-type branch December 7, 2023 16:50
@janober
Copy link
Member

janober commented Dec 13, 2023

Got released with n8n@1.21.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@valya valya valya approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivov @janober @valya